Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated asyncio.coroutines syntax from tests #663

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

Nothing4You
Copy link
Collaborator

@Nothing4You Nothing4You commented Jan 13, 2022

What do these changes do?

Remove legacy async syntax from tests, as this is not needed anymore for any currently supported python version.
tests._testutils.run_until_complete is not referenced anymore since moving to pytest.mark.run_loop in 819d4ec, therefore removed.

Are there changes in behavior for the user?

No.

Related issue number

No

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into CHANGES.txt folder

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #663 (87e0f56) into master (6887375) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #663   +/-   ##
=======================================
  Coverage   85.70%   85.70%           
=======================================
  Files          12       12           
  Lines        2085     2085           
  Branches      336      336           
=======================================
  Hits         1787     1787           
  Misses        228      228           
  Partials       70       70           
Flag Coverage Δ
ubuntu-latest_3.7_mariadb-10.2 81.93% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.3 81.93% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.4 81.93% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.5 81.93% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.6 81.93% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.7 81.93% <ø> (ø)
ubuntu-latest_3.7_mysql-5.7 82.81% <ø> (ø)
ubuntu-latest_3.7_mysql-8.0 84.73% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.2 82.34% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.3 82.34% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.4 82.34% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.5 82.34% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.6 82.34% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.7 82.34% <ø> (ø)
ubuntu-latest_3.8_mysql-5.7 83.21% <ø> (ø)
ubuntu-latest_3.8_mysql-8.0 85.04% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.2 82.34% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.3 82.34% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.4 82.34% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.5 82.34% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.6 82.34% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.7 82.34% <ø> (ø)
ubuntu-latest_3.9_mysql-5.7 83.21% <ø> (ø)
ubuntu-latest_3.9_mysql-8.0 85.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6887375...87e0f56. Read the comment docs.

tests._testutils.run_until_complete is not referenced anymore since moving to pytest.mark.run_loop in 819d4ec
@Nothing4You Nothing4You merged commit 6191960 into aio-libs:master Jan 26, 2022
@Nothing4You Nothing4You deleted the native-async branch January 28, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant