Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varying node versions & not using NPM clean install #8116

Closed
1 task done
steverep opened this issue Jan 30, 2024 · 0 comments · Fixed by #8140
Closed
1 task done

Varying node versions & not using NPM clean install #8116

steverep opened this issue Jan 30, 2024 · 0 comments · Fixed by #8140

Comments

@steverep
Copy link
Contributor

Is your feature request related to a problem?

For building llhttp, the docs, workflows, and Makefile all use npm install. This is not a particularly safe approach as it does not freeze the lock file. Instead, the npm ci command should be used.

In addition, I noticed that the current aiohttp CI builds with node 14, while llhttp itself just uses the default in GH hosted runners. Strongly recommend pinning this to the same version, and 14 is long out of maintenance. Version 18 is the maintenance LTS and 20 is the current LTS.

Describe the solution you'd like

  • All llhttp installs should use npm ci.
  • Consistently build llhttp with the same Node.js version (either current LTS or maintenance LTS).

Describe alternatives you've considered

n/a

Related component

Server, Client

Additional context

No response

Code of Conduct

  • I agree to follow the aio-libs Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant