Mypy coverage #5457
Mypy coverage #5457
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
| @@ -74,7 +74,7 @@ fmt format: | |||
|
|
|||
| .PHONY: mypy | |||
| mypy: | |||
| mypy --show-error-codes aiohttp tests | |||
| mypy | |||
There was a problem hiding this comment.
With no arguments, it uses the files and options in the config file.
| @@ -50,7 +51,7 @@ def __init__(self) -> None: | |||
| web.get("/v2.7/me/friends", self.on_my_friends), | |||
| ] | |||
| ) | |||
| self.runner = None | |||
| self.runner = web.AppRunner(self.app) | |||
There was a problem hiding this comment.
This example has clearly not been run in several years. :P
| files = aiohttp, examples, tests | ||
| check_untyped_defs = True | ||
| follow_imports_for_stubs = True | ||
| #disallow_any_decorated = True |
There was a problem hiding this comment.
These 2 commented out, we should consider in the future, but will need a ~50 errors to be cleaned up or ignored first.
Codecov Report
@@ Coverage Diff @@
## master #5457 +/- ##
=======================================
Coverage 97.17% 97.17%
=======================================
Files 41 41
Lines 8768 8769 +1
Branches 1404 1404
=======================================
+ Hits 8520 8521 +1
Misses 130 130
Partials 118 118
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@Dreamsorcerer would you take care of backporting plz? |
Co-authored-by: Sam Bull <git@sambull.org>
Co-authored-by: Sam Bull <git@sambull.org>
Co-authored-by: Sam Bull <git@sambull.org>
Provide some better Mypy coverage. Enables some more options that are useful and adds examples/ into the checker (which helps ensure our public API is correct, and helps keep the examples themselves up-to-date).