Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send custom per-request cookies even if session jar is empty #3515

Merged
merged 2 commits into from
Jan 10, 2019
Merged

Send custom per-request cookies even if session jar is empty #3515

merged 2 commits into from
Jan 10, 2019

Conversation

asvetlov
Copy link
Member

The issue was reported in gitter chat

@asvetlov asvetlov added the bug label Jan 10, 2019
@codecov-io
Copy link

Codecov Report

Merging #3515 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3515   +/-   ##
=======================================
  Coverage   97.92%   97.92%           
=======================================
  Files          44       44           
  Lines        8562     8562           
  Branches     1381     1381           
=======================================
  Hits         8384     8384           
  Misses         72       72           
  Partials      106      106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7706b5a...27dbdec. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jan 10, 2019 •
edited
Loading

Codecov Report

Merging #3515 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3515   +/-   ##
=======================================
  Coverage   97.92%   97.92%           
=======================================
  Files          44       44           
  Lines        8562     8562           
  Branches     1381     1381           
=======================================
  Hits         8384     8384           
  Misses         72       72           
  Partials      106      106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7706b5a...27dbdec. Read the comment docs.

@asvetlov asvetlov merged commit a86af67 into master Jan 10, 2019
@asvetlov asvetlov deleted the fix-client-cookies branch January 10, 2019 12:00
@asvetlov asvetlov restored the fix-client-cookies branch January 10, 2019 12:00
asvetlov added a commit that referenced this pull request Jan 10, 2019
@asvetlov
[3.5] Send custom per-request cookies even if session jar is empty (#…
5d3da6c 
…3515)

* Send custom per-request cookies even if session jar is empty

* Add changenote
(cherry picked from commit a86af67)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@mihajenko mihajenko mentioned this pull request Jan 10, 2019
Merged
3 tasks
asvetlov added a commit that referenced this pull request Jan 10, 2019
@asvetlov
[3.5] Send custom per-request cookies even if session jar is empty (#…
587da16 
…3515) (#3516)

* Send custom per-request cookies even if session jar is empty

* Add changenote
(cherry picked from commit a86af67)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
mihajenko added a commit to mihajenko/aiohttp that referenced this pull request Jan 14, 2019
@mihajenko
Add test for aio-libs#3515
1016f55
asvetlov pushed a commit that referenced this pull request Jan 14, 2019
@mihajenko @asvetlov
Add test for #3515 (#3517)
aa5cccb
asvetlov pushed a commit that referenced this pull request Jan 14, 2019
@mihajenko @asvetlov
[3.5] Add test for #3515 (#3517)
b5f1fea 
(cherry picked from commit aa5cccb)

Co-authored-by: Miha Jenko <mjenko@t-2.net>
asvetlov added a commit that referenced this pull request Jan 14, 2019
@asvetlov @mihajenko
[3.5] Add test for #3515 (#3517) (#3534)
e5971e3 
(cherry picked from commit aa5cccb)

Co-authored-by: Miha Jenko <mjenko@t-2.net>
@asvetlov asvetlov deleted the fix-client-cookies branch May 13, 2019 15:09
@lock lock bot added the outdated label May 20, 2020
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR bug outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asvetlov @codecov-io