ClientResponse.connection becomes None too early

[asvetlov]

Now ClientResponse._response_eof() cleans up self._connection on getting end of response's BODY.
For relative small bodies the method is called before even very first resp.read().

It works pretty well from content delivery perspective but raises another problem: there is no reliable way to get underlying socket options, in particular we need transport.get_extra_info('peercert').

In theory aiohttp could collect all data before connection releasing but there is no public asyncio API for providing all available transport's keys.
Moreover I could imagine situation where direct call is needed like tr.get_extra_info('socket').getsockopt(...).

I have no good proposal, keeping resp.connection until at least first resp.read() breaks pipelining if I understand correctly.
But I pretty sure the problem should be fixed.

@fafhrd91 please share your opinion.

[asvetlov]

@hellysmile ^^^

[fafhrd91]

I think current implementation works very well, I don't think we should change it.

I see several options:

• use api @asvetlov proposed Introduce session.make_request() API #2019
• introduce callback for "connection is available"
• custom Response class

[asvetlov]

First option is the best maybe. I should find time work working on it.

[asvetlov]

Should be fixed by implementing #2019 proposal

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new