-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate DataArray and Dataset level attributes in coarsening functions and regrid_vertical #513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is a great idea, and solves a long-standing difficulty with using these routines. Thanks.
I have a couple concerns about the implementation though. I'm happy to discuss if you don't fully agree with my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this Spencer! I wonder whether we want to set the default behavior to true (despite this being a "breaking" change). Certainly that is the behavior I almost always want.
This will fail until #513 is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks great!
This PR adds code to ensure that DataArray and Dataset level attributes are always propagated to the output objects through the coarsening functions as well as
regrid_vertical
.