Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image quality regression after repeated usage #3

Open
malipetek opened this issue Apr 6, 2017 · 2 comments
Open

Image quality regression after repeated usage #3

malipetek opened this issue Apr 6, 2017 · 2 comments

Comments

@malipetek
Copy link

hi, I used this script in my app,
After erasing ended, all image returns with erased parts removed and then module takes canvas and returns canvas. However if you use it on same bitmap 5-6 times distinguishable quality regression takes place. But its not like pixelating, more like gaussian blur. I tried context.imageSmoothingEnabled = false inside function with no luck.

@agilgur5
Copy link
Owner

Hmmm, thanks for bringing this up! I haven't a clue why that happened (haven't tested to see if it's a recurring issue, but I'd guess so) and I would think it's more to do with canvas internals than this library's usage.

If you've found out why or find a fix in the future, feel free to make a PR or comment back here

@agilgur5 agilgur5 changed the title Image quality regression Image quality regression after repeated usage May 25, 2017
@agilgur5
Copy link
Owner

Actually maybe this is caused by the getRGBA function? It appears to use ImageData correctly though, so probably not. Possibly affected by #1 but that shouldn't have induced any blur-like regression :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants