Rework displayed category reasoning. #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to have conflicts with the just merged #1149 can you resolve them? |
This new technique is both more performant, more readable and reduces boilerplate.
jpoiret
force-pushed
the
display-category-reasoning
branch
from
c0a00a0
to
a845cdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR improves the reasoning system for displayed categories, both in terms of ergonomy and performance. Proofs that were previously costly in terms of memory and time are now near instantaneous, and the proof terms are much more focused and readable.
We don't have many displayed category equality proofs right now, and I think this was probably due to how hard they were to use.