Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connected CW complexes #1133

Merged
merged 59 commits into from
Sep 19, 2024
Merged

Connected CW complexes #1133

merged 59 commits into from
Sep 19, 2024

Conversation

aljungstrom
Copy link
Contributor

This PR introduces the notion of an n-connected CW complex (in terms of trivial lower skeleta).

  • The main result is makeConnectedCW in CW.Connected which says that this is (merely) implied by the usual definition of connectedness. This is the main component of the proof of the Hurewicz theorem that I have in mind -- ping @rwbarton @owen-fool (we still need some other stuff first though).
  • Pushout squares and pasting lemmas are added to HITS.Pushout.
  • A bunch of minor lemmas about manipulating pushouts, cofibres, wedge sums, etc.
  • Many results concerning pushouts have been reparametrised with general universe levels. This makes this PR look a bit larger than it actually is...

@aljungstrom aljungstrom changed the title Cellular pointed Connected CW complexes Jun 5, 2024
@Trebor-Huang
Copy link
Contributor

Pasting lemmas would be really nice to have. Is this PR ready for merging?

@aljungstrom
Copy link
Contributor Author

Pasting lemmas would be really nice to have. Is this PR ready for merging?

I agree:-) I think this one is for Anders to review but he's on parental leave.

But let's ping him just to harass him a bit ;-) @mortberg

@felixwellen
Copy link
Collaborator

Who else would be a candidate to review it? Maybe @ecavallo and I can do it together once we are back from vacation? Or @rwbarton ?
Or did Anders insist on reviewing it himself?

@aljungstrom
Copy link
Contributor Author

No, anyone could do it I guess. It's a project that Anders is part of which is why I thought it'd be easier if he did it. But it doesn't matter to me.

Copy link
Collaborator

@felixwellen felixwellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff!
We have only some minor requests for more comments/renamings.

Cubical/Relation/Nullary/Properties.agda Outdated Show resolved Hide resolved
Cubical/HITs/Wedge/Properties.agda Outdated Show resolved Hide resolved
Cubical/HITs/Wedge/Properties.agda Show resolved Hide resolved
Cubical/HITs/Pushout/Properties.agda Outdated Show resolved Hide resolved
Cubical/CW/Subcomplex.agda Show resolved Hide resolved
Cubical/CW/Connected.agda Outdated Show resolved Hide resolved
Cubical/CW/Connected.agda Outdated Show resolved Hide resolved
@aljungstrom
Copy link
Contributor Author

@felixwellen Thanks for reviewing! I think I've seen to all the comments now.

@felixwellen
Copy link
Collaborator

Yes, great!

@felixwellen felixwellen merged commit 53e400e into agda:master Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants