simplify isSet<SomeAlgebraicStructure> #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthiasHu
commented
Aug 25, 2023
| @@ -139,7 +139,7 @@ module _ ((G , abgroupstr _ _ _ GisGroup) : AbGroup ℓ) where | |||
| AbGroup→CommMonoid .snd .CommMonoidStr.isCommMonoid .IsCommMonoid.·Comm = IsAbGroup.+Comm GisGroup | |||
|
|
|||
| isSetAbGroup : (A : AbGroup ℓ) → isSet ⟨ A ⟩ | |||
| isSetAbGroup A = isSetGroup (AbGroup→Group A) | |||
| isSetAbGroup A = is-set (str A) | |||
There was a problem hiding this comment.
This is the single case where the open ...Str ... method was impractical, since the file already opens multiple records with is-set fields.
|
Thanks for the nice refactoring! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies, or at least harmonizes, the definitions of the following lemmas:
Each of them is a simple
is-setafter opening the respective<Something>Str. In the case ofAlgebraandOrderedCommMonoid, theis-setfield was impossible to use since it was exported twice from the respective records; I fixed that by hiding one copy (as it was already done inRing, for example).