Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructions vs Instances #765

Open
anuyts opened this issue Apr 28, 2022 · 1 comment
Open

Constructions vs Instances #765

anuyts opened this issue Apr 28, 2022 · 1 comment
Labels
order Structuring, enforcing conventions, renaming, ...

Comments

@anuyts
Copy link
Contributor

anuyts commented Apr 28, 2022

Within the Cubical.Categories module, one distinguishes between Instances and Constructions. The only distinguishing criterion that I can think of is that constructions are instances with "many" parameters and instances are constructions with "few" parameters. This seems rather arbitrary, so I would suggest to merge these modules in the interest of finding stuff more easily.

@felixwellen felixwellen added the order Structuring, enforcing conventions, renaming, ... label May 22, 2022
@maxsnew
Copy link
Collaborator

maxsnew commented May 9, 2024

I agree with this. It is the only part of the library where this distinction is made, e.g., AbGroup has direct product under Instances. And right now it's not even consistent as Functors is under Instances.

I propose we just move everything under Constructions to Instances. It's a breaking change but easy to fix downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
order Structuring, enforcing conventions, renaming, ...
Projects
None yet
Development

No branches or pull requests

3 participants