Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same as previous, lowercase area/ region name when saving file #52

Open
KristenOmori-NOAA opened this issue Sep 4, 2024 · 6 comments
Open

Comments

@KristenOmori-NOAA
Copy link

vroom::vroom_write(here::here(year, "data", "raw", paste0(area, "_bts_specimen_data.csv")),

Same as with the bts length data... to make the raw data query compatible with the afscasssess, can you make the file output area name to lowercase?

@BenWilliams-NOAA
Copy link
Contributor

i'll adjust, but should all work if enter the area as lowercase to start with

@KristenOmori-NOAA
Copy link
Author

Actually, can you change to goa_bts_length_specimen_data.csv

@KristenOmori-NOAA
Copy link
Author

the area name gets changed to upper case in the "global" section of that function.

@BenWilliams-NOAA
Copy link
Contributor

nah it changes to ar = toupper(area)

@BenWilliams-NOAA
Copy link
Contributor

Actually, can you change to goa_bts_length_specimen_data.csv

I'm gonna recommend against this - mostly for historical reasons. The specimen data has always been associated with age information/samples so combining these would increase the likelihood of downstream confusion

@KristenOmori-NOAA
Copy link
Author

That's fine, would you be able to change the file name to match what goes into the afscassess::bts_length_comp data file then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants