Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextureWidget crashes when there are cached video textures #471

Closed
speigg opened this issue May 8, 2017 · 2 comments
Closed

TextureWidget crashes when there are cached video textures #471

speigg opened this issue May 8, 2017 · 2 comments

Comments

@speigg
Copy link

speigg commented May 8, 2017

getTextureFromSrc from the TextureWidget assumes that each textureCache hash is simply JSON string, which is not always the case. See:
https://github.com/aframevr/aframe/blob/6a236273bfd6bd673e36ff4d376135906ba57ed6/src/systems/material.js#L207

When trying to JSON.parse() a textureCache hash that is generated from a video texture, the TextureWidget throws an "Unexpected token a in JSON" error.
@kfarr kfarr mentioned this issue Jan 25, 2023
Open
@vincentfretin
Copy link
Contributor

This has been fixed by #680

@vincentfretin
Copy link
Contributor

@dmarcos please close this issue.

@dmarcos dmarcos closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmarcos @vincentfretin @speigg