Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] EncoderClassifier produces end of life warning #1144

Closed
TonyBagnall opened this issue Feb 7, 2024 · 8 comments · Fixed by #1421
Closed

[BUG] EncoderClassifier produces end of life warning #1144

TonyBagnall opened this issue Feb 7, 2024 · 8 comments · Fixed by #1421
Assignees
Labels
bug Something isn't working classification Classification package deep learning Deep learning related

Comments

@TonyBagnall
Copy link
Contributor

TonyBagnall commented Feb 7, 2024

Describe the bug

the EncoderClassifier produces this warning
"TFA has entered a minimal maintenance and release mode until a planned end of life in May 2024."

Steps/Code to reproduce the bug

from aeon.testing.data_generation import make_example_3d_numpy
from aeon.classification.deep_learning._encoder import EncoderClassifier
X, y = make_example_3d_numpy(n_cases=4, n_timepoints=20, n_labels=2, return_y=True)
enc = EncoderClassifier()

Expected results

no warnings

Actual results

C:\Code\aeon\venv\lib\site-packages\tensorflow_addons\utils\tfa_eol_msg.py:23: UserWarning: 
TensorFlow Addons (TFA) has ended development and introduction of new features.
TFA has entered a minimal maintenance and release mode until a planned end of life in May 2024.
Please modify downstream libraries to take dependencies from other repositories in our TensorFlow community (e.g. Keras, Keras-CV, and Keras-NLP). 
For more information see: https://github.com/tensorflow/addons/issues/2807 
  warnings.warn(

When fitting you get this

WARNING:root:The given value for groups will be overwritten.
WARNING:root:The given value for groups will be overwritten.
WARNING:root:The given value for groups will be overwritten.
WARNING:root:The given value for groups will be overwritten.

Versions

No response

@TonyBagnall TonyBagnall added bug Something isn't working classification Classification package deep learning Deep learning related labels Feb 7, 2024
@TonyBagnall TonyBagnall changed the title [BUG] EncoderClassifier [BUG] EncoderClassifier produces end of life warning Feb 7, 2024
@hadifawaz1999
Copy link
Contributor

That's a shame they will deprecate the package... Will try to implement the instance normalization myself then :) thanks for putting this up @TonyBagnall !

@TonyBagnall
Copy link
Contributor Author

pinging this @hadifawaz1999 since it says end of life May 2024

@hadifawaz1999
Copy link
Contributor

pinging this @hadifawaz1999 since it says end of life May 2024

Will take care of it in the next couple of days

@hadifawaz1999
Copy link
Contributor

When removing tensorflow addons and no longer have a bound on tensorflow, for some reason the combincation of python 3.12 and MAC OS 13 gets stuck in CI at one test for infinite loop, after seeing the details, it shows that its stucking on some transformation test https://github.com/aeon-toolkit/aeon/actions/runs/9355511121/job/25750819343?pr=1421

@TonyBagnall
Copy link
Contributor Author

only transformer that uses tensorflow is RocketGPU, but this problem predates that I think?

@hadifawaz1999
Copy link
Contributor

its meged to main now, but before that it was still happening, so yeah the problem predates it

@TonyBagnall
Copy link
Contributor Author

where are we with this bug? Is it purely the MAcOS?

@hadifawaz1999
Copy link
Contributor

where are we with this bug? Is it purely the MAcOS?

its being fixed here: #1421
but MACOS is blocking it @TonyBagnall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working classification Classification package deep learning Deep learning related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants