-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analytics SDK fixes #36
Conversation
Changed analytics SDK to return entire response Unit test coverage to 100% env file support for e2e tests
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
===========================================
+ Coverage 94.04% 100.00% +5.95%
===========================================
Files 3 3
Lines 168 168
Branches 15 15
===========================================
+ Hits 158 168 +10
+ Misses 10 0 -10
Continue to review full report at Codecov.
|
In general, we should not test specific output because the test server contents might change. Let's change it to test for success only like so: https://github.com/adobe/aio-lib-target/blob/master/e2e/e2e.js |
Retracting e2e code comments, will file a separate issue. |
Added openapi spec validation
Changed analytics SDK to return entire response
Unit test coverage to 100%
env file support for e2e tests
How Has This Been Tested?
unit tests
Types of changes
Checklist: