Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics SDK fixes #36

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Analytics SDK fixes #36

merged 1 commit into from
Apr 22, 2020

Conversation

sandeep-paliwal
Copy link
Contributor

@sandeep-paliwal sandeep-paliwal commented Apr 20, 2020

Added openapi spec validation
Changed analytics SDK to return entire response
Unit test coverage to 100%
env file support for e2e tests

How Has This Been Tested?

unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Changed analytics SDK to return entire response
Unit test coverage to 100%
env file support for e2e tests
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #36 into master will increase coverage by 5.95%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #36      +/-   ##
===========================================
+ Coverage   94.04%   100.00%   +5.95%     
===========================================
  Files           3         3              
  Lines         168       168              
  Branches       15        15              
===========================================
+ Hits          158       168      +10     
+ Misses         10         0      -10     
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (+7.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update affe4d4...6df1402. Read the comment docs.

@meryllblanchet meryllblanchet added the enhancement New feature or request label Apr 20, 2020
test/index.test.js Show resolved Hide resolved
test/index.test.js Show resolved Hide resolved
test/index.test.js Show resolved Hide resolved
test/index.test.js Show resolved Hide resolved
test/index.test.js Show resolved Hide resolved
test/index.test.js Show resolved Hide resolved
test/index.test.js Show resolved Hide resolved
test/index.test.js Show resolved Hide resolved
test/index.test.js Show resolved Hide resolved
@shazron
Copy link
Member

shazron commented Apr 22, 2020

In general, we should not test specific output because the test server contents might change. Let's change it to test for success only like so: https://github.com/adobe/aio-lib-target/blob/master/e2e/e2e.js

@shazron
Copy link
Member

shazron commented Apr 22, 2020

Retracting e2e code comments, will file a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants