Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classes_to_exclude is not filtering proteins correctly #133

Closed
ardagoreci opened this issue Jan 31, 2024 · 1 comment · Fixed by #137
Closed

classes_to_exclude is not filtering proteins correctly #133

ardagoreci opened this issue Jan 31, 2024 · 1 comment · Fixed by #137

Comments

@ardagoreci
Copy link

Hi @elkoz,

I noticed while visualizing the proteins that setting the classes_to_exclude method is not properly filtering the required classes. It runs with no issues, but it still returns proteins that are homomeric or heteromeric.
It might be removing some of the homomers/heteromers, but I haven't tested if it does.

Here is the code that I used for filtering and a few of the resulting proteins:

Screen Shot 2024-01-31 at 01 08 55 Screen Shot 2024-01-31 at 01 08 21
@elkoz elkoz mentioned this issue Feb 6, 2024
@elkoz elkoz closed this as completed in #137 Feb 6, 2024
@elkoz
Copy link
Collaborator

elkoz commented Feb 6, 2024

Just in case, also keep in mind that this is filtering based on the biounit level. It is possible (and pretty common) that e.g. a heteromer protein has a single chain biounit, such biounits won't be filtered out by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants