Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Add package.json to each plugin #3072

Closed
24 tasks done
oliverfoster opened this issue Mar 15, 2021 · 10 comments
Closed
24 tasks done

General: Add package.json to each plugin #3072

oliverfoster opened this issue Mar 15, 2021 · 10 comments

Comments

@OlaoluwaM
Copy link

Hey @oliverfoster is this issue still available

@oliverfoster
Copy link
Member Author

Yes it is. 👍

@OlaoluwaM
Copy link

Hey @oliverfoster , would it work to simply rename each bower.json file to a package.json?

@oliverfoster
Copy link
Member Author

oliverfoster commented Apr 19, 2021

Nono, we need both files at the same time for the moment. Effectively the framework needs to be functional and up-to-date with minimal effort, and allow the npm architecture to be built around it for a smooth transition later. So no forking/branches/breaks but at the cost of some duplication.

@OlaoluwaM
Copy link

Hey @oliverfoster I think the link for adapt-contrib-core is broken. It directed me to a 404 page

@oliverfoster
Copy link
Member Author

It hasn't been created yet. I'll talk it through with the team on their Monday meeting. I effectively need to move src/core into it's own adapt-contrib-core and link it back into the current src/core folder.

@OlaoluwaM
Copy link

Hey @oliverfoster , I am done. Let me know when adapt-contrib-core is up so I can complete that. Thanks

@oliverfoster
Copy link
Member Author

superb, thankyou!

@OlaoluwaM
Copy link

No problem

@oliverfoster
Copy link
Member Author

@OlaoluwaM

adapt-contrib-core is ready, I have added a package.json in the work already. Thank you for doing the others, it was a great help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants