Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon support #306

Closed
joe-replin opened this issue Feb 22, 2023 · 0 comments · Fixed by adaptlearning/adapt-contrib-vanilla#396 or adaptlearning/adapt_framework#3369
Closed

Favicon support #306

joe-replin opened this issue Feb 22, 2023 · 0 comments · Fixed by adaptlearning/adapt-contrib-vanilla#396 or adaptlearning/adapt_framework#3369
Assignees
Labels
enhancement New feature or request released

Comments

@joe-replin
Copy link
Contributor

joe-replin commented Feb 22, 2023

Subject of the issue/enhancement/features

It is the one console error that is displayed in every new Adapt build. May we place the Adapt icon at the root level for starters? With future thought for the AAT, I imagine we'll need a method to change this.

  • Future state: the favicon is adjustable somewhere in the AAT UI
  • Quicker fix: the favicon lives in the theme and is placed at the root of the build once compiled

Expected behaviour

Use a default favicon so the error goes away.

Actual behaviour

A console error is displayed in every new Adapt build.

Screenshots (if you can)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
2 participants