Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make max_workers configurable #978

Merged
merged 10 commits into from
Jan 17, 2022
Merged

Make max_workers configurable #978

merged 10 commits into from
Jan 17, 2022

Conversation

danieljanes
Copy link
Member

@danieljanes danieljanes commented Dec 31, 2021 •
edited
Loading

  • Implement change
  • Add test
  • Add to release notes

@sisco0
Copy link
Contributor

sisco0 commented Jan 1, 2022

I created a Pull Request for this Pull Request branch so hopefully, the CI error related to mypy would disappear.

@sisco0 sisco0 mentioned this pull request Jan 1, 2022
Merged
@sisco0
Copy link
Contributor

sisco0 commented Jan 4, 2022

The related pull request has been merged but we need to create a test for this. I am unsure of the assertions expression.

@danieljanes danieljanes self-assigned this Jan 5, 2022
@danieljanes danieljanes marked this pull request as ready for review January 17, 2022 15:04
@tanertopal tanertopal enabled auto-merge (squash) January 17, 2022 20:48
@tanertopal
Copy link
Member

@danieljanes @sisco0 approved. Looks good to me! Thank you both.

@tanertopal tanertopal merged commit 4068eb9 into main Jan 17, 2022
@tanertopal tanertopal deleted the max-workers branch January 17, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

Assignees

@danieljanes danieljanes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieljanes @sisco0 @tanertopal