Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jax Example #906

Merged
merged 48 commits into from
Mar 21, 2022
Merged

Jax Example #906

merged 48 commits into from
Mar 21, 2022

Conversation

mariaboerner1987
Copy link
Contributor

  • create a "from centralized to federated" code example with JAX and linear regression
  • add a README for code example
  • add pyproject.toml for code example
  • add jax documentation
  • add jax links to Flower documentation index

@mariaboerner1987 mariaboerner1987 added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 17, 2021
@danieljanes danieljanes removed their assignment Jan 5, 2022
danieljanes
danieljanes requested changes Mar 19, 2022
View reviewed changes
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code example and documentation look good, I've added a few suggestions. One open question: should we call this "from centralized to federated" or "quickstart JAX"?

doc/source/example-jax-from-centralized-to-federated.rst Outdated Show resolved Hide resolved
doc/source/example-jax-from-centralized-to-federated.rst Outdated Show resolved Hide resolved
doc/source/example-jax-from-centralized-to-federated.rst Outdated Show resolved Hide resolved
doc/source/example-jax-from-centralized-to-federated.rst Outdated Show resolved Hide resolved
doc/source/example-jax-from-centralized-to-federated.rst Outdated Show resolved Hide resolved
examples/jax_from_centralized_to_federated/pyproject.toml Outdated Show resolved Hide resolved
examples/jax_from_centralized_to_federated/pyproject.toml Outdated Show resolved Hide resolved
examples/jax_from_centralized_to_federated/pyproject.toml Outdated Show resolved Hide resolved
examples/jax_from_centralized_to_federated/pyproject.toml Outdated Show resolved Hide resolved
examples/jax_from_centralized_to_federated/jax_training.py Outdated Show resolved Hide resolved
mariaboerner1987 and others added 9 commits March 21, 2022 13:47
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
ebd042b 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
7eef5ca 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
b462394 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
ef9ed90 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
24f941a 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update examples/jax_from_centralized_to_federated/pyproject.toml
d4bec98 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update examples/jax_from_centralized_to_federated/pyproject.toml
c97c1d1 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update examples/jax_from_centralized_to_federated/jax_training.py
1a380a6 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update examples/jax_from_centralized_to_federated/pyproject.toml
c6d8ecc 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987
Copy link
Contributor Author

Code example and documentation look good, I've added a few suggestions. One open question: should we call this "from centralized to federated" or "quickstart JAX"?

From centralized to federated makes more sense to me.

mariaboerner1987 and others added 23 commits March 21, 2022 14:44
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
cf47c05 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
c0b0301 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
a8fd3b1 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
ded910c 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
b8ff460 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
7f8dada 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
a16797a 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
f72e37b 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
f26a101 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
e975062 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
702a766 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987
remove mxnet parameter description
5ff2f63
@mariaboerner1987
Merge branch 'jax_example' of https://github.com/adap/flower into jax…
422da32 
…_example
@mariaboerner1987
remove accuracy description
12b66cc
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
bcc7660 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
de179b1 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987 @danieljanes
Update doc/source/example-jax-from-centralized-to-federated.rst
60f5092 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987
remove mxnet description
2c63f32
@mariaboerner1987
remove mxnet description
4384080
@mariaboerner1987 @danieljanes
Apply suggestions from code review
40539c6 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@mariaboerner1987
change sentences for federation
4b53258
@mariaboerner1987
resolve merge conflict
417ac14
@mariaboerner1987
remove space
c845be7
@danieljanes danieljanes enabled auto-merge (squash) March 21, 2022 14:54
@danieljanes danieljanes merged commit b73a1d2 into main Mar 21, 2022
@danieljanes danieljanes deleted the jax_example branch March 21, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees

@mariaboerner1987 mariaboerner1987

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariaboerner1987 @danieljanes