Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "ray" import check so it works on Colab #866

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

tanertopal
Copy link
Member

@tanertopal tanertopal commented Oct 11, 2021

Fixes a bug where ray is not found although its installed. The new approach uses importlib.util.find_spec which searches at multiple locations and works also on Colab: https://docs.python.org/3.8/library/importlib.html?highlight=pkg_resources#importlib.util.find_spec

@tanertopal tanertopal merged commit 2600493 into main Oct 11, 2021
@tanertopal tanertopal deleted the fix_ray_import_detection branch October 11, 2021 10:49
@danieljanes danieljanes added this to the 0.18.0 milestone Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants