Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparing to enable SSL/TLS for gRPC server #842

Merged
merged 44 commits into from
Jan 5, 2022
Merged

Preparing to enable SSL/TLS for gRPC server #842

merged 44 commits into from
Jan 5, 2022

Conversation

tanertopal
Copy link
Member

Add SSL/TLS option to gRPC server including tests. When this is merged it should be trivial to expose the functionality on the public API

@tanertopal tanertopal force-pushed the secure_grpc_server branch 9 times, most recently from 05da792 to e493f2a Compare September 14, 2021 10:33
danieljanes
danieljanes requested changes Sep 14, 2021
View reviewed changes
src/py/flwr/server/grpc_server/certificates/certificates.py Outdated Show resolved Hide resolved
src/py/flwr/server/grpc_server/certificates/__init__.py Outdated Show resolved Hide resolved
src/py/flwr/server/grpc_server/grpc_server.py Outdated Show resolved Hide resolved
src/py/flwr/server/grpc_server/grpc_server.py Outdated Show resolved Hide resolved
src/py/flwr/server/grpc_server/grpc_server.py Outdated Show resolved Hide resolved
@tanertopal tanertopal marked this pull request as draft September 14, 2021 11:17
@tanertopal tanertopal marked this pull request as ready for review September 14, 2021 20:03
@tanertopal tanertopal mentioned this pull request Sep 15, 2021
Merged
@tanertopal tanertopal added the enhancement New feature or request label Jan 5, 2022
danieljanes
danieljanes previously approved these changes Jan 5, 2022
View reviewed changes
@danieljanes danieljanes enabled auto-merge (squash) January 5, 2022 11:53
danieljanes
danieljanes requested changes Jan 5, 2022
View reviewed changes
src/py/flwr/server/grpc_server/grpc_server.py Outdated Show resolved Hide resolved
src/py/flwr/server/grpc_server/grpc_server.py Outdated Show resolved Hide resolved
tanertopal and others added 2 commits January 5, 2022 13:47
@tanertopal @danieljanes
Update src/py/flwr/server/grpc_server/grpc_server.py
32f2d36 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal
Fix docs
db60b0f
@tanertopal tanertopal enabled auto-merge (squash) January 5, 2022 12:49
danieljanes
danieljanes previously approved these changes Jan 5, 2022
View reviewed changes
danieljanes
danieljanes previously approved these changes Jan 5, 2022
View reviewed changes
@tanertopal tanertopal merged commit 5b92ef6 into main Jan 5, 2022
@tanertopal tanertopal deleted the secure_grpc_server branch January 5, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@jafermarq jafermarq Awaiting requested review from jafermarq

@pedropgusmao pedropgusmao Awaiting requested review from pedropgusmao

Assignees

@tanertopal tanertopal

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tanertopal @danieljanes