Create get properties msg #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedropgusmao
requested review from
danieljanes,
jafermarq and
tanertopal
as code owners
danieljanes
reviewed
Sep 8, 2021
… the Scalar in transport_pb2.pyi
…One in typing.py and one in grpc
danieljanes
requested changes
Sep 14, 2021
danieljanes
requested changes
Sep 14, 2021
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
danieljanes
requested changes
Sep 17, 2021
There was a problem hiding this comment.
Thanks for the updates @pedropgusmao. Just a few minor things left, almost there!
removing properties from wrapper and forwarding call to numpy_client attribute.
I removed `self.properties` from wrapper and forwarded the `get_properties` call to `keras_client` attribute.
danieljanes
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.