Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of fedbn on client side #696

Merged
merged 10 commits into from
Apr 19, 2021
Merged

Conversation

MeiruiJiang
Copy link
Contributor

Implementation of FedBN
change model with BN layers added
modified fuctions: get/set_prameters

MeiruiJiang and others added 8 commits April 13, 2021 11:14
Co-authored-by: Maria Boerner <69673117+mariaboerner1987@users.noreply.github.com>
Co-authored-by: Maria Boerner <69673117+mariaboerner1987@users.noreply.github.com>
Co-authored-by: Maria Boerner <69673117+mariaboerner1987@users.noreply.github.com>
Co-authored-by: Maria Boerner <69673117+mariaboerner1987@users.noreply.github.com>
Co-authored-by: Maria Boerner <69673117+mariaboerner1987@users.noreply.github.com>
Co-authored-by: Maria Boerner <69673117+mariaboerner1987@users.noreply.github.com>
Co-authored-by: Maria Boerner <69673117+mariaboerner1987@users.noreply.github.com>
Changing back to default settings to be consistent with other examples.
@danieljanes
Copy link
Member

@MeiruiJiang thanks for the PR, this looks great!
I'll run some regression tests and add a flag that enables users to enable/disable FedBN, then we can merge

@MeiruiJiang
Copy link
Contributor Author

@MeiruiJiang thanks for the PR, this looks great!
I'll run some regression tests and add a flag that enables users to enable/disable FedBN, then we can merge

Great! Thanks and look forward to the Flower with FedBN.

Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add the flag to enable/disable FedBN in a follow-up PR.

@danieljanes danieljanes merged commit 812627e into adap:main Apr 19, 2021
@danieljanes
Copy link
Member

danieljanes commented Apr 19, 2021

Merged, thanks again for the PR @MeiruiJiang!

joshua-sterner pushed a commit to joshua-sterner/flower that referenced this pull request Jun 11, 2021
Co-authored-by: Maria Boerner <maria@adap.com>
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants