Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework) Add override config to Run #3730

Merged
merged 12 commits into from
Jul 8, 2024
Merged

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Jul 7, 2024

Issue

Description

The Run object doesn't contain the override_config dict that is needed on both the ServerApp and the ClientApp.

Related issues/PRs

The current PR is blocked by #3728 and #3729

Proposal

Explanation

Add override_config to the Run object and make the necessary changes across the codebase.

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@charlesbvll charlesbvll marked this pull request as ready for review July 8, 2024 12:32
@danieljanes danieljanes enabled auto-merge (squash) July 8, 2024 14:18
@danieljanes danieljanes changed the title feat(framework) Add override config to Run feat(framework) Add override config to Run Jul 8, 2024
@danieljanes danieljanes disabled auto-merge July 8, 2024 14:20
@danieljanes danieljanes enabled auto-merge (squash) July 8, 2024 14:20
@danieljanes danieljanes merged commit 7c2c6c3 into main Jul 8, 2024
30 checks passed
@danieljanes danieljanes deleted the add-overrides-to-run branch July 8, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants