feat(framework) Make NodeState capture partition-id
#3695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafermarq
changed the title
NoseState capture partition-idNodeState capture partition-id
danieljanes
reviewed
Jun 29, 2024
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
danieljanes
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeStatecarries thepartition-idthat theContextshould useSuperNodegains--partition-idflag<context>.partition_idis unused in this PR -- it will be used in a follow up PR--partition-idwhen launching aSuperNode. The original motivation for doing so was so to make it clear that thinking about data partitions (in the sense of "one client gets one of the N locally available partitions") does not quite fit how deployment setups work.