-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(framework) Add SuperExec servicer #3606
Conversation
run = self.plugin.start_run(request.fab_file) | ||
self.runs[run.run_id] = run.proc | ||
return StartRunResponse(run_id=run.run_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting the run can fail. We should immediately start with error handling here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danieljanes Should we make the run_id
and proc
of RunTracker
optionals? Or should we make the return type of start_run
optional? I think the second option is the most straightforward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danieljanes I updated it but do you think we should add an error field to the proto definition of the response?
Issue
Description
Related issues/PRs
Proposal
Explanation
Checklist
#contributions
)Any other comments?