Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Implement DriverAPI GetRun #3580

Merged
merged 39 commits into from
Jun 20, 2024
Merged

feat(framework) Implement DriverAPI GetRun #3580

merged 39 commits into from
Jun 20, 2024

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Jun 11, 2024 •
edited
Loading

Depends on #3578

  • Added run abstract property to Driver class.
  • Implemented the property in GrpcDriver and InMemoryDriver.
  • Updated unit tests accordingly.
  • Made the run_id argument mandatory for GrpcDriver and InMemoryDriver.
  • Moved the run creation process out from the drivers.

@panh99 panh99 marked this pull request as ready for review June 12, 2024 14:16
danieljanes
danieljanes previously approved these changes Jun 19, 2024
View reviewed changes
@danieljanes danieljanes enabled auto-merge (squash) June 20, 2024 11:52
@danieljanes danieljanes merged commit 02fe051 into main Jun 20, 2024
29 checks passed
@danieljanes danieljanes deleted the impl-get-run-driver branch June 20, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq left review comments

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panh99 @danieljanes @jafermarq