Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework:skip) Call delete_node on shutdown #3531

Merged
merged 6 commits into from
Jun 9, 2024
Merged

feat(framework:skip) Call delete_node on shutdown #3531

merged 6 commits into from
Jun 9, 2024

Conversation

charlesbvll
Copy link
Member

Issue

Description

With #3090 we allow clients to exit gracefully but they are not deleted directly on the SuperLink, this can cause "phantom clients" being sampled.

Related issues/PRs

To merge after #3090

Proposal

Explanation

Checklist

  • Implement proposed change
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@jafermarq jafermarq mentioned this pull request Jun 8, 2024
Merged
@charlesbvll charlesbvll changed the base branch from main to better-client-exit June 9, 2024 16:52
@charlesbvll charlesbvll marked this pull request as ready for review June 9, 2024 16:52
@danieljanes danieljanes merged commit 100ba85 into better-client-exit Jun 9, 2024
@danieljanes danieljanes deleted the add-delete-node-on-shutdown branch June 9, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesbvll @danieljanes