Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(framework) Update CLI SSL flags #3512

Merged
merged 14 commits into from
May 28, 2024
Merged

refactor(framework) Update CLI SSL flags #3512

merged 14 commits into from
May 28, 2024

Conversation

danielnugraha
Copy link
Contributor

Issue

Description

Having flag that expects multiple argument is confusing to users.

Related issues/PRs

Proposal

Explanation

Update CLI SSL flag to multiple flags that each expects one argument and update the docs accordingly.

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

src/py/flwr/server/app.py Outdated Show resolved Hide resolved
Copy link
Member

@Robert-Steiner Robert-Steiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the /doc/source/how-to-run-flower-using-docker.rst and /doc/source/how-to-upgrade-to-flower-next.rst file. The --certificates flag also appears in the translations but I'm not sure if need to change them manually.

@tanertopal tanertopal enabled auto-merge (squash) May 28, 2024 16:13
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tanertopal tanertopal merged commit 7371789 into main May 28, 2024
29 checks passed
@tanertopal tanertopal deleted the update-ssl-flag branch May 28, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants