-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(examples) Update XGBoost quick-start example for independent object instantiation #3426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks fine, thanks @yan-gao-GY. I think one more PR is needed to convert this fully to use ClientApp
and ServerApp
. (We should place start_client
and start_server
within a if __name__ == "__main__"
for this). Let's draft another PR for this upgrade.
You'll also need to update the PR title to conform to the new format. I think something like fix(examples) Update XGBoost quickstart examples for independent object instantiation
could work.
@chongshenng Thanks a lot for your comments and suggestions! Do we want to fully replace |
Let's do that later in a different PR. |
Agreed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Issue
Description
The xgboost-quickstart example instantiates xgb object at the first round and persist over FL rounds. This is ok for long-running clients in deployment mode within cross-silo settings. However, it is not feasible to use Flower Simulation and migrate to Flower Next.
Proposal
Implement the same Xgb client as the comprehensive xgb example does, where the xgb object is instantiated independently every single round. No need to persist the xgb object over FL rounds.
Changelog entry