Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples) Update XGBoost quick-start example for independent object instantiation #3426

Merged
merged 8 commits into from
May 30, 2024

Conversation

yan-gao-GY
Copy link
Contributor

Issue

Description

The xgboost-quickstart example instantiates xgb object at the first round and persist over FL rounds. This is ok for long-running clients in deployment mode within cross-silo settings. However, it is not feasible to use Flower Simulation and migrate to Flower Next.

Proposal

Implement the same Xgb client as the comprehensive xgb example does, where the xgb object is instantiated independently every single round. No need to persist the xgb object over FL rounds.

Changelog entry

@yan-gao-GY yan-gao-GY added the Examples Add or update a Flower example label May 10, 2024
Copy link
Contributor

@chongshenng chongshenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine, thanks @yan-gao-GY. I think one more PR is needed to convert this fully to use ClientApp and ServerApp. (We should place start_client and start_server within a if __name__ == "__main__" for this). Let's draft another PR for this upgrade.

You'll also need to update the PR title to conform to the new format. I think something like fix(examples) Update XGBoost quickstart examples for independent object instantiation could work.

@yan-gao-GY yan-gao-GY changed the title Update xgboost-quickstart example for independent xgb object instantiation fix(examples) Update XGBoost quick-start example for independent object instantiation May 28, 2024
@yan-gao-GY
Copy link
Contributor Author

@chongshenng Thanks a lot for your comments and suggestions!

Do we want to fully replace start_client and start_server now? I saw other examples keep both and using Flower Next with a preview label.

@jafermarq
Copy link
Contributor

@chongshenng Thanks a lot for your comments and suggestions!

Do we want to fully replace start_client and start_server now? I saw other examples keep both and using Flower Next with a preview label.

Let's do that later in a different PR.

@chongshenng
Copy link
Contributor

@chongshenng Thanks a lot for your comments and suggestions!
Do we want to fully replace start_client and start_server now? I saw other examples keep both and using Flower Next with a preview label.

Let's do that later in a different PR.

Agreed.

@jafermarq jafermarq enabled auto-merge (squash) May 30, 2024 10:31
Copy link
Contributor

@chongshenng chongshenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jafermarq jafermarq merged commit a1216e2 into main May 30, 2024
29 checks passed
@jafermarq jafermarq deleted the xgb-quickstart-update branch May 30, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Examples Add or update a Flower example
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants