Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare State to enable node_id verification #3389

Merged
merged 5 commits into from
May 6, 2024

Conversation

danielnugraha
Copy link
Contributor

Issue

Description

Current client authentication implementation does not verify whether node_id is assigned to a given public key.

Related issues/PRs

Proposal

Explanation

Implement functions in State that enables verification of node_id assigned to a given public key.

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update the changelog entry below
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Changelog entry

Any other comments?

@danieljanes danieljanes changed the title Add verify node_id state Prepare State to enable node_id verification May 6, 2024
@danieljanes danieljanes merged commit b2ed467 into main May 6, 2024
28 checks passed
@danieljanes danieljanes deleted the add-verify-nodeid-state branch May 6, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants