Improve ServerApp logging #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljanes
previously approved these changes
Mar 8, 2024
danieljanes
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
The current logs for ServerApp are not very readable for most users.
Related issues/PRs
N/A
Proposal
Explanation
Add color to logs, a simpler format, as well as setting
INFOlog level as a default.For ServerApp, we properly format the results printed at the end of FL, separate the different steps clearly and better use log levels.
Checklist
#contributions)Changelog entry
We made our logging system simpler and clearer to read! You can now see some colours and some nicely formatted results.
Any other comments?
N/A