Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make copyright year in Flower docs dynamic #2699

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

Robert-Steiner
Copy link
Member

Issue

The copyright year is currently hardcoded. This PR adds a bit of python code to make it dynamic.

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update changelog
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@tanertopal
Copy link
Member

@Robert-Steiner can you modify the other conf.py and also add a test that checks all sphinx conf.py files for that code so that it's ensured that in the future we always use that dynamic copyright year?

@Robert-Steiner Robert-Steiner force-pushed the make-copyright-year-dynamic branch 2 times, most recently from a04bcd0 to 709dd07 Compare December 8, 2023 15:40
@Robert-Steiner
Copy link
Member Author

Robert-Steiner commented Dec 8, 2023

@Robert-Steiner can you modify the other conf.py and also add a test that checks all sphinx conf.py files for that code so that it's ensured that in the future we always use that dynamic copyright year?

I have modified the other conf.py files and added a test in the CI. Let me know what you think. I used the ::error annotation to let the errors appear in the summary. here is an example https://github.com/adap/flower/actions/runs/7143334049

@tanertopal tanertopal enabled auto-merge (squash) December 11, 2023 16:11
@tanertopal tanertopal merged commit 346b595 into main Dec 15, 2023
30 checks passed
@tanertopal tanertopal deleted the make-copyright-year-dynamic branch December 15, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants