Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong status Code int value in Android SDK #2623

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

danielnugraha
Copy link
Contributor

@danielnugraha danielnugraha commented Nov 21, 2023

Issue

Description

Android SDK status Code int value starts at 1, but it should starts at 0.

Related issues/PRs

Proposal

Explanation

Fix the status Code int value to starts with 0 instead of 1.

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update changelog
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@danieljanes danieljanes merged commit 1ad038b into main Nov 21, 2023
27 checks passed
@danieljanes danieljanes deleted the android-status-update branch November 21, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants