Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fastai E2E test #2093

Merged
merged 12 commits into from
Jul 12, 2023
Merged

Add fastai E2E test #2093

merged 12 commits into from
Jul 12, 2023

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Jul 12, 2023 •
edited
Loading

Issue

Description

There is no E2E test for the fastai framework.

Related issues/PRs

N/A

Proposal

Explanation

Add E2E test for fastai.

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@charlesbvll charlesbvll marked this pull request as ready for review July 12, 2023 13:43
@tanertopal tanertopal merged commit 9afb822 into main Jul 12, 2023
17 checks passed
@tanertopal tanertopal deleted the add-fastai-e2e branch July 12, 2023 13:45
tanertopal added a commit that referenced this pull request Jul 12, 2023
@tanertopal
Merge branch 'main' into improve_ci_speed
873de90 
* main:
  Move pandocs install into workflow (#2098)
  Add defaults to action (#2097)
  Ensure build tool versions are all the same (#2096)
  Optimize CI file structure DRY (#2083)
  Add fastai E2E test (#2093)
  Updated Template Baseline (#2077)
alessiomora pushed a commit to alessiomora/flower that referenced this pull request Aug 30, 2023
@charlesbvll @alessiomora
Add fastai E2E test (adap#2093)
50e6887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesbvll @tanertopal