Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mxnet examples dependency versions #1982

Merged
merged 11 commits into from
Jul 4, 2023
Merged

Conversation

danielnugraha
Copy link
Contributor

@danielnugraha danielnugraha commented Jun 30, 2023

Issue

Description

There are some inconsistencies with the examples that uses mxnet as its dependencies, resulting in error when poetry tries to resolve the dependencies. Using mxnet with version 1.7.1 results in error.

Related issues/PRs

See also #1980 and #1981.

Proposal

Explanation

Following changes in pyproject.toml and requirements.txt are made to the examples that uses mxnet as its dependencies:

  1. Fix mxnet version to 1.6.0
  2. Fix python version to >=3.8, <3.11.
  3. ^ on other dependencies are removed.
  4. Flwr local dependency path is changed to the latest flwr-nightly version.
  5. Flwr version is fixed to >=1.0, <2.0.

Checklist

  • Implement proposed change
  • Make CI checks pass

Any other comments?

@danielnugraha danielnugraha changed the title Update mxnet deps versions Update mxnet examples Jun 30, 2023
@danielnugraha danielnugraha changed the title Update mxnet examples Update mxnet examples dependency versions Jun 30, 2023
examples/quickstart_mxnet/pyproject.toml Outdated Show resolved Hide resolved
@tanertopal tanertopal enabled auto-merge (squash) July 4, 2023 13:04
@tanertopal tanertopal dismissed danieljanes’s stale review July 4, 2023 14:37

New line was added

@tanertopal tanertopal merged commit b87e7e2 into main Jul 4, 2023
@tanertopal tanertopal deleted the update-mxnet-examples branch July 4, 2023 14:44
tanertopal added a commit that referenced this pull request Jul 5, 2023
* main:
  Remove line with typo from script (#2001)
  Fix simulation error caused by Pydantic version in Ray (#2002)
  Update mxnet examples dependency versions (#1982)
  Update torch version in pyproject.toml files (#1993)
  Update tensorflow examples dependency versions (#1984)
  Fix the baseline template docstrings (#1983)
  Fix Baselines CI PyLint error by using Resampling (#1998)
  Make tensorflow optional when using tensorboard (#1879)
  Update dependencies for MXNet example (#1988)
  Fix `starlette` vulnerability (#1992)
  Fix vulnerability detected by Dependabot (#1990)
  Fix dependabot critical errors (#1989)
  Add Ruff UP check (#1946)
  Update torch examples dependency versions (#1981)
  Remove && from the end of lines in test.sh (#1979)
  Baselines docs updates (#1977)
  Fixes GitHub CI issue because of behaviour change (#1976)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants