Avoid CI job to marked as failure if requirements.txt check fails #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljanes
approved these changes
May 29, 2023
tanertopal
added a commit
that referenced
this pull request
Jun 27, 2023
* main: (314 commits) Fix D401 First line of docstring should be in imperative mood (#1924) Fix D105 Missing docstring in magic method (#1923) Fix D202 No blank lines allowed after function docstring (#1920) Fix a minor typo in the documentation (#1922) Fix docformatter docstrings (#1919) Add SecAggMsg field to Task Message (#1893) Ignore typing for Ray to fix CI (#1925) Update `mypy` to 1.3.0 and fix typing issues (#1877) Upgrade black and docformatter, format ipynb (#1902) Updated minor error on the documentation, (3rd config dict print) instead of batch_size prints 2 to local_epochs prints 2 (#1903) Avoid CI job to marked as failure if requirements.txt check fails (#1906) Make check-requirements-txt.sh optional (#1905) Add default address for grpc-rere (#1900) Update docs dependencies, fix warnings (#1899) Add quickstart iOS documentation (#1897) Auto-generate requirements.txt to sync with pyproject.toml automatically (#1873) Fix updated formatting (#1890) Fix code documentation in aggregate_krum() (#1887) Remove redundant warning check for strategies subclassing FedAvg (#1855) Reformat server for FedBuff (#1888) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems continue-on-error will still mark the test as failed. I missed that in the review of the previous PR which made it optional.
Related issues/PRs