Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Driver API and Fleet API #1546

Merged
merged 15 commits into from
Jan 13, 2023
Merged

Align Driver API and Fleet API #1546

merged 15 commits into from
Jan 13, 2023

Conversation

danieljanes
Copy link
Member

@danieljanes danieljanes commented Jan 9, 2023 •
edited
Loading

@danieljanes danieljanes marked this pull request as ready for review January 9, 2023 16:55
@danieljanes danieljanes mentioned this pull request Jan 9, 2023
Merged
1 task
tanertopal
tanertopal requested changes Jan 10, 2023
View reviewed changes
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Overall it looks really good! Left few comments, we should discuss.

examples/mt-pytorch/driver.py Show resolved Hide resolved
src/proto/flwr/proto/driver.proto Show resolved Hide resolved
src/proto/flwr/proto/fleet.proto Show resolved Hide resolved
@tanertopal tanertopal enabled auto-merge (squash) January 13, 2023 03:21
@tanertopal tanertopal merged commit 9572253 into main Jan 13, 2023
@tanertopal tanertopal deleted the harmonize-driver-fleet branch January 13, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieljanes @tanertopal