Update sklearn example's server and client #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @gxenos ! Changes look good, could you please also update the |
added 2 commits
July 29, 2022 18:41
|
Thanks for the quick reply. Added the flwr version. |
danieljanes
approved these changes
Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #1346
What does this implement/fix? Explain your changes.
Fixes both the server and the client implementations.
Changes the evaluate_fn passed to built-in strategies like FedAvg to take the three parameters required by Flower 1.0.0.
Changes the naming of Weights to NDArrays.
Adds a configuration object of type flwr.server.ServerConfig in the start_server function, containing the num_rounds instead of the old config dictionary.
Any other comments?
I tested it with the run.sh script and it works now