Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use keyword-only arguments in public API #1338

Merged
merged 7 commits into from
Jul 27, 2022
Merged

Use keyword-only arguments in public API #1338

merged 7 commits into from
Jul 27, 2022

Conversation

danieljanes
Copy link
Member

No description provided.

@danieljanes danieljanes marked this pull request as ready for review July 27, 2022 14:15
@tanertopal tanertopal enabled auto-merge (squash) July 27, 2022 14:21
@tanertopal tanertopal merged commit 998e0c2 into main Jul 27, 2022
@tanertopal tanertopal deleted the keyword-args-only branch July 27, 2022 14:32
@alexkyllo
Copy link

Could you please explain what is the reason for this change? I found that a lot of code I wrote just a few months ago using Flower v0.19.0 is broken by this when I try to run it with v1.0.0. I do understand what I need to do to make my code forward compatible, but what I don't understand is the justification for why this change was made, because no reason was given here or in the release notes--appreciate if you could shed some light on the decision.

All arguments must be passed as keyword arguments (#1338)
Pass all arguments as keyword arguments, positional arguments are not longer supported. Code that uses positional arguments (e.g., start_client("127.0.0.1:8080", FlowerClient())) must add the keyword for each positional argument (e.g., start_client(server_address="127.0.0.1:8080", client=FlowerClient())).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants