New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update request timeouts draft #1189

Merged

tanertopal merged 2 commits into request_timeouts from request_timeouts_2

Apr 19, 2022

Member

danieljanes commented Apr 18, 2022

This PR updates #1162 with the following minor changes:

Updated wording of comments
Remember & re-raise StopIteration
Use different key names in dicts to reduce potential for ambiguity


          Update request timeouts draft

674c9db

danieljanes requested a review from tanertopal as a code owner

April 18, 2022 17:31


          Update comment

97e6e44

tanertopal approved these changes

View reviewed changes

tanertopal merged commit e5627b2 into request_timeouts

tanertopal deleted the request_timeouts_2 branch

April 19, 2022 10:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet