Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to not shutdown ray if already initialised #1177

Merged
merged 2 commits into from
Apr 17, 2022
Merged

Conversation

jafermarq
Copy link
Contributor

This a short PR enabling the user to decide whether start_simulation should do ray.shutdown() if an existing Ray runtime is already initialized. In some settings, we might want to have Ray already running before calling start_simulation if, for example, some other tasks have to run first before FL.

@danieljanes
Copy link
Member

danieljanes commented Apr 12, 2022

Good idea, thanks for the PR @jafermarq ! I've approved it, there just a lint issue (too-many-locals) that needs to be resolved. In this particular case I'd say it's ok to just ignore it.

@danieljanes danieljanes merged commit 11f6317 into main Apr 17, 2022
@danieljanes danieljanes deleted the keep_ray_alive branch April 17, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants