Add Python version modularity in venv scripts (#1504)

Co-authored-by: Taner Topal <taner@adap.com>
adap · Dec 11, 2022 · dcd6657 · dcd6657
1 parent dac3450
commit dcd6657
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 6 deletions.
diff --git a/baselines/dev/venv-create.sh b/baselines/dev/venv-create.sh
@@ -2,5 +2,11 @@
 set -e
 cd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"/../
 
-pyenv virtualenv 3.7.12 baselines-3.7.12
-echo baselines-3.7.12 > .python-version
+version=${1:-3.7.12}
+
+# Check if the directory for the Python version does not exist and if so, 
+# install the right Python version through pyenv
+[[ ! -d $PYENV_ROOT/versions/$version ]] && pyenv install $version
+
+pyenv virtualenv $version baselines-$version
+echo baselines-$version > .python-version
diff --git a/baselines/dev/venv-delete.sh b/baselines/dev/venv-delete.sh
@@ -2,4 +2,6 @@
 set -e
 cd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"/../
 
-pyenv uninstall -f baselines-3.7.12
+version=${1:-3.7.12}
+
+pyenv uninstall -f baselines-$version
diff --git a/dev/venv-create.sh b/dev/venv-create.sh
@@ -2,5 +2,11 @@
 set -e
 cd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"/../
 
-pyenv virtualenv 3.7.12 flower-3.7.12
-echo flower-3.7.12 > .python-version
+version=${1:-3.7.12}
+
+# Check if the directory for the Python version does not exist and if so, 
+# install the right Python version through pyenv
+[[ ! -d $PYENV_ROOT/versions/$version ]] && pyenv install $version
+
+pyenv virtualenv $version flower-$version
+echo flower-$version > .python-version
diff --git a/dev/venv-delete.sh b/dev/venv-delete.sh
@@ -2,4 +2,6 @@
 set -e
 cd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"/../
 
-pyenv uninstall -f flower-3.7.12
+version=${1:-3.7.12}
+
+pyenv uninstall -f flower-$version