Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception messages #16

Open
adam-paterson opened this issue Oct 6, 2017 · 5 comments
Open

Fix exception messages #16

adam-paterson opened this issue Oct 6, 2017 · 5 comments

Comments

@adam-paterson
Copy link
Owner

adam-paterson commented Oct 6, 2017

API errors are in the format:

{  
   "code":401,
   "error":"Not Authorized",
   "description":"2017-10-06T08:57:02-04:00, Error ERCDPLTFRM-DNLKUPERR occurred when accessing https://gateway.watsonplatform.net/tone-analyzer/api/v3/tone?version=2017-10-06&sentences=1, Tran-Id: gateway-dp01-307987946 - Invalid UserId and/or Password. Please confirm that your credentials match the end-point you are trying to access. A common error is trying to use credentials from an experimental or beta release against a GA release or vice versa"
}

We need to amend \IBM\Watson\Common\Api\AbstractApi::handleErrors() to account for that format.

@adam-paterson adam-paterson self-assigned this Oct 6, 2017
@adam-paterson adam-paterson added this to the 1.0.0 milestone Oct 6, 2017
@adam-paterson adam-paterson removed their assignment Oct 6, 2017
@adam-paterson
Copy link
Owner Author

@StyxOfDynamite if you wanted a quick one you could look at this

@StyxOfDynamite
Copy link

@adam-paterson I'll take a look over the weekend if thats cool?

@adam-paterson
Copy link
Owner Author

adam-paterson commented Oct 6, 2017 via email

@patrikpihlstrom
Copy link

I'd like to take a look at this if it's not currently being worked on.

@adam-paterson
Copy link
Owner Author

@patrikpihlstrom I’m actually in the middle of refactoring a lot of the foundation classes for the SDK.

If you’re looking to get involved in the project for hacktoberfest I’m happy to write something up for you to work on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants