Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement]: Upload files with their names #80

Closed
kittaakos opened this issue May 15, 2020 · 5 comments
Closed

[enhancement]: Upload files with their names #80

kittaakos opened this issue May 15, 2020 · 5 comments

Comments

@kittaakos
Copy link

Inspired by this.

I am not sure if this is possible at all as the artifacts are zipped, but I would like to upload files with their names. With Azure, it is possible to upload a directory and all artifacts will have their original file name.

Azure config:

 - task: PublishBuildArtifacts@1
    inputs:
      pathtoPublish: path/to/dir/with/artifacts/created/by/the/previous/task/
      artifactName: 'Arduino Pro IDE - Applications'
    displayName: Publish

Azure artifacts:
Screen Shot 2020-05-15 at 09 22 29

I have shamelessly copied your code 😊, modified it a bit, and set up another GH action that tries to demonstrate what I would consider a useful upload-feature. See here: https://github.com/kittaakos/upload-artifact-as-is

What do you think? Thanks for your time!

@kittaakos
Copy link
Author

Just for completeness, I created a GH action with upload/artifact and upload/artifact-as-is.

upload/artifact without name specified:
Screen Shot 2020-05-15 at 13 38 26

upload/artifact-as-is:
Screen Shot 2020-05-15 at 13 59 51

The latter is closer to what Azure provides.

@konradpabjan
Copy link
Collaborator

That's a pretty ingenious action! 😀 It's open source! It's meant to be forked and modified so you can do whatever you want.

I would throw this into the bucket of "we need better UI". If you click on one of your zip artifacts for example you will still get a zip of a zip (which is super annoying). In the artifacts UI for Azure DevOps you can browse everything, there is a nested directory structure you get the size. We want to get to the same point for GitHub actions.

If a user has only a few files in their artifact (4 in your example) with no nested structure then I could see this being a viable option. However... artifacts tend to have a some sort of directory structure and i think your action would pretty much ignore it. The UI will also only display 100 artifacts (100 files in your case). If someone for example uploaded node_modules with you action, things would quickly start to 🧨🔥

When we currently upload artifacts with actions/upload-artifact we actually upload each file individually one-by-one without any zipping during upload. The single zip that is later available for download is just a UI limitation where everything gets thrown together into a single file because we don't support downloading and browsing files individually (yet).

@kittaakos
Copy link
Author

Thank you, @konradpabjan!

I would throw this into the bucket of "we need better UI".

I agree. Ideally, I want to browse the files the same way I can do it on Azure (without maintaining my super-naive GH Action customization).

example you will still get a zip of a zip (which is super annoying)

Yes, I have noticed.

We want to get to the same point for GitHub actions.

Is there a GH issue for that, was it already added to some roadmap on your side? Can you share a link if there is such an enhancement ticket? I want to close this issue and track that instead.

@konradpabjan
Copy link
Collaborator

Internally we are tracking this (please be aware there are a lot of other things we are working on that take priority over such a bug feature). Nothing so far on our public roadmap so I can't give any ETA on when this might come around.

The closest thing to a UI update is this issue which I recommend following: #14

@kittaakos
Copy link
Author

The closest thing to a UI update is this issue which I recommend following: #14

👍

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants