-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruby: add ruby 2.7 and 3.0 into bootstrap script #766
Conversation
b9cca86
to
07eb334
Compare
refreshed the PR against the latest main branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it's better or not to have a matrix example in the starter workflow.
To me, a matrix feels like an orthogonal concern, and any workflow can of course be augmented with a matrix.
So I think it'd be better to just ruby-version: '3.0'
here and no matrix.
Related: #769
If we merge this, let's squash it to avoid back-and-forth history and extra merges. |
sync with main branch quote versions remove redundant bundle install Signed-off-by: Rui Chen <rui@chenrui.dev>
9852afe
to
650a7b3
Compare
squashed all my commits. |
matrix: | ||
ruby-version: ['2.6', '2.7', '3.0'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a matrix seems good to me and aligns with our other CI workflows (Python, Node).
Thanks for your contributions! 🎉 |
ruby: add ruby 2.7 and 3.0 into bootstrap script
relates to https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/