ruby: add ruby 2.7 and 3.0 into bootstrap script #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenrui333
force-pushed
the
update-ruby-script
branch
from
b9cca86
to
07eb334
Compare
|
refreshed the PR against the latest main branch |
eregon
reviewed
Jan 5, 2021
There was a problem hiding this comment.
I'm not sure if it's better or not to have a matrix example in the starter workflow.
To me, a matrix feels like an orthogonal concern, and any workflow can of course be augmented with a matrix.
So I think it'd be better to just ruby-version: '3.0' here and no matrix.
Related: #769
|
If we merge this, let's squash it to avoid back-and-forth history and extra merges. |
sync with main branch quote versions remove redundant bundle install Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
force-pushed
the
update-ruby-script
branch
from
9852afe
to
650a7b3
Compare
|
squashed all my commits. |
joshmgross
approved these changes
Jan 5, 2021
Comment on lines
+21
to
+22
| matrix: | ||
| ruby-version: ['2.6', '2.7', '3.0'] |
There was a problem hiding this comment.
Adding a matrix seems good to me and aligns with our other CI workflows (Python, Node).
|
Thanks for your contributions! 🎉 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby: add ruby 2.7 and 3.0 into bootstrap script
relates to https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/