Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support a .python-version file #291

Closed
indifferentghost opened this issue Dec 9, 2021 · 3 comments · Fixed by #336
Closed

Support a .python-version file #291

indifferentghost opened this issue Dec 9, 2021 · 3 comments · Fixed by #336
Labels
feature request New feature or request to improve the current logic

Comments

@indifferentghost
Copy link

Description:
The 2.5.0 release of actions/setup-node released support determine the node version via an .nvmrc file at the root. I think it'd be prudent to use the pyenv standard of a .python-version file to support this.

Justification:
It'd be nice to be DRY when specifying versions across multiple actions.

Are you willing to submit a PR?
@indifferentghost indifferentghost added feature request New feature or request to improve the current logic needs triage labels Dec 9, 2021
@nikita-bykov
Copy link
Contributor

Hello @indifferentghost, thanks for your feature request! We will look at it.

@indifferentghost
Copy link
Author

Using a .*-version file is already defined by ruby/setup-ruby as well.

@nikita-bykov nikita-bykov mentioned this issue Dec 20, 2021
Closed
@fregante
Copy link

I'll append my request for Heroku’s runtime.txt format

@adilosa adilosa mentioned this issue Feb 10, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add support for python-version-file adilosa/setup-python
3 participants
@fregante @indifferentghost @nikita-bykov