-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
permission issue causing failure to cache on windows #1024
Comments
Hello @geemus, Thank you for creating this issue and we will look into it :) |
Hello @geemus 👋, |
Thanks for checking on this. I changed some things to ensure there is a lock file present, but it doesn't seem to have made a difference. FWIW we run the same jobs on mac and ubuntu and they worked fine both before and after (and everything but the cache save afterward seems to work on windows). I also tried to setup a minimal reproduction case, but so far I haven't figured out how to get it to fail (it seems to work just fine, probably similar to what you saw). |
Hello there👋, |
It's still happening consistently in our main repo, but I have been unable to extract the right mix of things to get it to reproduce elsewhere so far. |
Hello @geemus 👋,
Hope this helps! |
Thanks, those are good pointers. Since it is a monorepo, I wonder if perhaps other things are claiming a lock on that directory such as you suggest (like perhaps the go-setup stuff). I'll try to look at my reproduction efforts again and see if I can figure something out soon. |
I'll share the repo I made trying to repro in case that is helpful, but unfortunately I still haven't managed to get it to actually repro: https://github.com/anchordotdev/node-windows-repro I think it's pretty similar to what is happening where we see the error with the exception that there we also are doing a go build after doing go setup. Not sure that this is helpful, but I'm also not sure what else to try so I thought I would share what I have so far in case it helps. |
Hello @geemus , |
Description:
Post job cleanup fails with permission issues:
Action version:
actions/setup-node@v4
Platform:
Runner type:
Tools version:
node 20.10.0
npm (? I didn't specify, so the default I suppose)
Repro steps:
Here are what I think would be the relevant bits from our setup:
I'll note that we just have a
package.json
and no lock at present in case that is relevant.Expected behavior:
I expected the caching to "just work" with this setup, as it does with the same invocation on mac/ubuntu.
Actual behavior:
Setup node and the rest of the action work fine, but the cleanup/caching fails (so there is never a cache to be used).
The text was updated successfully, but these errors were encountered: