Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm warning when using gha-runner-scale-set as app dependency #3620

Open
4 tasks done
rfinnie-epic opened this issue Jun 23, 2024 · 1 comment
Open
4 tasks done

Helm warning when using gha-runner-scale-set as app dependency #3620

rfinnie-epic opened this issue Jun 23, 2024 · 1 comment
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers

Comments

@rfinnie-epic
Copy link

rfinnie-epic commented Jun 23, 2024

Checks

Controller Version

0.9.2

Deployment Method

Helm

Checks

  • This isn't a question or user support case (For Q&A and community support, go to Discussions).
  • I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

Chart.yaml:

---
apiVersion: 'v2'
name: 'arc-runners'
description: 'GitHub arc runners'
type: 'application'
version: '0.1.0'

dependencies:
  - name: 'gha-runner-scale-set'
    version: '0.9.2'
    repository: 'oci://ghcr.io/actions/actions-runner-controller-charts'

values.yaml:

---
gha-runner-scale-set:
  githubConfigUrl: 'https://github.com/enterprises/example'
  githubConfigSecret: 'runner-pat'
  # ...

Run:

helm install my-label --namespace arc-runners --values ./values.yaml .

Describe the bug

When the above chart is installed or upgraded while pulling in gha-runner-scale-set as a dependency, it produces the following Helm warning:

Release "my-label" does not exist. Installing it now.
coalesce.go:286: warning: cannot overwrite table with non table for arc-runners.gha-runner-scale-set.githubConfigSecret (map[github_token:])
NAME: my-label
LAST DEPLOYED: Sun Jun 23 15:30:22 2024
NAMESPACE: arc-runners
STATUS: deployed
REVISION: 1
TEST SUITE: None

This warning appears to be harmless as it does successfully use the runner-pat k8s secret, but I'm not sure if it's a error on the upstream chart, or with Helm itself.

Describe the expected behavior

No warning

Additional Context

See above

Controller Logs

N/A

Runner Pod Logs

N/A
@rfinnie-epic rfinnie-epic added bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers labels Jun 23, 2024
Copy link
Contributor

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers
Projects
None yet
Development

No branches or pull requests

1 participant